LucasWerkmeister created this task. LucasWerkmeister added a project: Wikidata. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION As a tool developer, I want to embed diffs generated by Wikibase in my tool, in order to present an edit to my users. **Problem:** Wikibase wraps time values in diffs in `<h4>` elements. On Wikibase pages, this looks fine, due to the stylesheets in effect (I’m not sure if the relevant stylesheets are by Wikibase or general to MediaWiki): F28620045: Screenshot_2019-04-11 Difference between revisions of Lara Méndez López (Q20535136) - Wikidata.png <https://phabricator.wikimedia.org/F28620045> However, when embedded in an external tool a using different set of stylesheets, the heading becomes disturbingly large: F28620049: Screenshot_2019-04-11 SpeedPatrolling.png <https://phabricator.wikimedia.org/F28620049> F28620050: Screenshot_2019-04-11 SpeedPatrolling(1).png <https://phabricator.wikimedia.org/F28620050> I’m not sure why we use `<h4>` elements for this. (They seem to have been introduced in PS4 of I29c083b31c <https://gerrit.wikimedia.org/r/116761/>.) Semantically, I’m pretty sure the date values are not headings. This also causes at least one other issue, see T87021 <https://phabricator.wikimedia.org/T87021>. As far as I can tell from the code, quantity and globe coordinate diffs also use `<h4>` elements, though I don’t recall those being problematic in SpeedPatrolling – I suppose they’re just less frequent. **Example:** - random example edit on Wikidata: https://www.wikidata.org/w/index.php?diff=910428737 - the same edit in SpeedPatrolling: https://tools.wmflabs.org/speedpatrolling/diff/910428737/ **Acceptance criteria:** - time, quantity and globe coordinate diffs no longer use heading elements TASK DETAIL https://phabricator.wikimedia.org/T220772 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: LucasWerkmeister Cc: Aklapper, LucasWerkmeister, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
