Hanna_Petruschat_WMDE added a comment.

  Hi @Jakob_WMDE 
  I tested and found some issues. Some are not 100% related to this task, but 
I'll note them all here to not forget them.
  
  1. the border of the alias fields are higher than the other entry fields, 
probably because there is padding between the entry fields and the outline 
indicating a fake field. Can we make it work that everything has the same size?
  2. the borders of the entry fields should have a 2px border-radius
  3. when hitting the x to cancel, the entries are being published. This is for 
all entry fields (label, descriptions, alias)
  4. at breakpoint 3 (all entry fields next to each other), the entry fields 
are not aligned at the same heights. the description fields are 1 px lower.
  
  I'm not a 100% sure if one of this is related to that ticket. If not, I'm 
more than happy to put this to done and copy/paste the above to a new "bug" 
ticket.

TASK DETAIL
  https://phabricator.wikimedia.org/T218690

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Hanna_Petruschat_WMDE
Cc: Jakob_WMDE, Hanna_Petruschat_WMDE, Pablo-WMDE, Aklapper, Lea_WMDE, 
alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to