akosiaris added a comment.
@Tarrow , @WMDE-leszek I 've noticed 3 things while working on the above
- The service seems to be configurable to reach directly out to the wikidata
endpoint. e.g. `WIKIBASE_REPO:
'{env(WIKIBASE_REPO,https://www.wikidata.org/w)}'`. Since, in the general case,
this goes via the edge caches (possibly polluting them with artificial
requests, and limits operational flexibility, e.g. in the case of a datacenter
switchover we can't really switch the app without switching the edge layer, we
've been defaulting to talking to internal endpoints and sending a `Host: `
HTTP for the identification of the exact project. Would it be possible to add
that functionality? (or guide me on how this is achieved if it is already
implemented).
- There was no `x-amples` stanza to `/termbox` endpoint. We need this for
monitoring checks so I went ahead and added one in
https://gerrit.wikimedia.org/r/#/c/wikibase/termbox/+/509391. Lemme know what
you think.
- The app does not emit statsd metrics for requests (it does however emit
nodejs heap and GC stats). This should be rather easy to add as service-runner
wraps it very nicely. See
https://github.com/wikimedia/service-runner#metric-reporting
What exactly you want to do for that is up to you, but up to now services
have been using
https://github.com/wikimedia/service-template-node/blob/master/lib/util.js#L107
to wrap the route handlers which provides them out of the box with requests
rates per endpoints, latencies per endpoint, errors and so on. I highly suggest
that.
For service specific stats, e.g. how many time language=de has been passed as
a request, `options.metrics.increment` is what has been used up to now as they
have invariably been of a counter nature.
Overall I think we are ready to deploy to staging, production will have to
wait a bit until we solve at least the first 2 items. The 3rd is not a hard
blocker but I am willing to bet you want stats :-)
I also think we should schedule a training session for how deployers deploy
code in the pipeline/kubernetes environment.
TASK DETAIL
https://phabricator.wikimedia.org/T220402
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: akosiaris
Cc: fsero, mobrovac, Matthias_Geisler_WMDE, Pablo-WMDE, Dzahn, Addshore,
Tarrow, Lea_WMDE, WMDE-leszek, Jakob_WMDE, Aklapper, akosiaris, darthmon_wmde,
alaa_wmde, joker88john, Legado_Shulgin, CucyNoiD, Nandana, NebulousIris,
thifranc, AndyTan, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci,
Davinaclare77, Adrian1985, Qtn1293, Cpaulf30, Lahi, Gq86, Baloch007,
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls,
Hfbn0, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Zppix,
Maathavan, _jensen, rosalieper, Liudvikas, Wong128hk, Eevans, thcipriani,
Hardikj, Wikidata-bugs, aude, Lydia_Pintscher, dduvall, faidon,
Jdforrester-WMF, Mbch331, Jay8g, fgiunchedi
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
