Pablo-WMDE added a comment.
Hi @Hanna_Petruschat_WMDE, I looked into your change requests - thanks for the very precise instructions. There are a few questions, though. > 1 Could you change the font weight in the buttons and the headline from 700 to 500 There are two challenges a) For the button this diverges from OOUI (where "bold" = 700 is in use <https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/src/themes/wikimediaui/elements.less$10>). Is this intended? Should this change apply for our button component in general or is this mean exclusively for the buttons contained in the "You are not logged in" overlay? b) font-weight support for different fonts is a delicate subject <https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#Fallback_weights>. Depending on the device and the available fonts some numeric weights do share the same actual font used. In my case e.g. all values from 100 to 500 result in the same visible weight, consequently for me buttons & headline would then look like "normal text". > 2. Could you change the line heights from 1 to 1.2 Will do > 3. Could you change the font weight of the message text from 400 to 300 Again, this change effectively causes no visual change on my device. Depending on the fonts installed the very specific numeric values may make sense or not. This is not to say that this change does not bring value to may devices, just wanted to bring it to your attention so it is a conscious decision. FWIW these are the weights (basically by the book) that famous bootstrap <https://github.com/twbs/bootstrap/blob/master/scss/_variables.scss#L297> uses. TASK DETAIL https://phabricator.wikimedia.org/T221831 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
