Lucas_Werkmeister_WMDE added a comment.
MobileFrontend hooks into `GetDifferenceEngine` to return an
`InlineDifferenceEngine` on Special:MobileFrontend;
`ContentHandler::getSlotDiffRenderer` then returns a
`DifferenceEngineSlotDiffRenderer` instead of the `TextSlotDiffRenderer` we
expect in `EntitySchemaSlotDiffRenderer`:
if ( get_class( $slotDiffRenderer ) === TextSlotDiffRenderer::class ) {
// To keep B/C, when SlotDiffRenderer is not overridden for a given
content type
// but DifferenceEngine is, use that instead.
$differenceEngine = $this->createDifferenceEngine( $context );
if ( get_class( $differenceEngine ) !== DifferenceEngine::class ) {
// TODO turn this into a deprecation warning in a later release
LoggerFactory::getInstance( 'diff' )->info(
'Falling back to DifferenceEngineSlotDiffRenderer', [
'modelID' => $this->getModelID(),
'DifferenceEngine' => get_class(
$differenceEngine ),
] );
$slotDiffRenderer = new DifferenceEngineSlotDiffRenderer(
$differenceEngine );
}
}
Perhaps we should just instantiate a fresh `TextSlotDiffRenderer` ourselves
if that’s what we really need.
TASK DETAIL
https://phabricator.wikimedia.org/T224545
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, darthmon_wmde, Premeditated,
pdehaye, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Jonas,
abian, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g,
Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
