alaa_wmde added a comment.
In T224541#5220395 <https://phabricator.wikimedia.org/T224541#5220395>, @Lucas_Werkmeister_WMDE wrote: > Currently, we have this in `WikibaseRepo`: > > private function newEntityTermStoreWriter(): EntityTermStoreWriter { > $termStoreMigrationStage = $this->settings->getSetting( 'tmpTermStoreMigrationStage' ); > > if ( $termStoreMigrationStage === MIGRATION_WRITE_BOTH ) { > return new MultiTermStoreWriter( > $this->getOldEntityTermStoreWriter(), > $this->getNewEntityTermStoreWriter() > ); > } > > if ( $termStoreMigrationStage === MIGRATION_WRITE_NEW ) { > return $this->getNewEntityTermStoreWriter(); > } > > return $this->getOldEntityTermStoreWriter(); > } > > private function getOldEntityTermStoreWriter(): EntityTermStoreWriter { > return $this->getStore()->getTermIndex(); > } > > private function getNewEntityTermStoreWriter(): EntityTermStoreWriter { > return new DelegatingEntityTermStoreWriter( > $this->getPropertyTermStore(), > $this->getItemTermStore() > ); > } > > > I can only assume that this predates the current migration plan, because it doesn’t really fit it very well: it assumes that we’ll do a migration across all entities at the same time, whereas we want to do properties first, and then items only up to a certain numeric ID. Yeap that was introduced too early, without much attention to the actual migration plan. (I do remember rejecting that change, but maybe I'm confusing it with something else). TASK DETAIL https://phabricator.wikimedia.org/T224541 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, alaa_wmde Cc: Lucas_Werkmeister_WMDE, Aklapper, alaa_wmde, E.S.A-Sheild, darthmon_wmde, Premeditated, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
