mkroetzsch added a comment.

> This is not correct, original structure can be recovered


Then I misunderstood the transformation that was proposed. My impression was 
that a statement with three qualifier snaks: P1 V1, P1 V2, 
https://phabricator.wikimedia.org/P2 V3 would be stored as two statements, one 
with qualifiers P1 V1, https://phabricator.wikimedia.org/P2 V3, and one with 
qualifiers P1 V2, https://phabricator.wikimedia.org/P2 V3. In this case, one 
would not be able to distinguish this from the case where two statements with 
two qualifiers each had been given originally. Could you explain what kind of 
transformation you had in mind?

> Scan of the database shows there are no entries generating more than 15 
> qualifier splits


My point was that an attacker could craft a single statement that makes you 
index millions of statements. It's clear that such statements are not in the 
current data, since they are hopefully not needed. Again this depends on my 
(possibly incorrect) understanding of your intended transformation.


TASK DETAIL
  https://phabricator.wikimedia.org/T86278

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, mkroetzsch
Cc: Aklapper, Smalyshev, Lydia_Pintscher, Multichill, Magnus, daniel, 
JeroenDeDauw, JanZerebecki, aude, mkroetzsch, Denny, Sjoerddebruin, 
Tobi_WMDE_SW, jkroll, Wikidata-bugs, GWicke, Manybubbles



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to