Addshore added a comment.

  So we could get rid of:
  
  - statement guids
  - all hashes
  - language keys (actually already done for items)
  - some keys from complex values:
    - timevalues (before, after)
    - possibly some others.
  
  We can either use the current approach which is to define keys which should 
be ignored at all levels of the JSON, or create a slightly more complex layered 
method of filtering.
  
  The current list is:
  
                return [
                        'language',
                        'site',
                        'type',
                ];
  
  and could be something like:
  
                return [
                        'language',
                        'site',
                        'type',
                        'hash',
                        'id',
                        'before',
                        'after',
                ];
  
  but this would have some slightly unexpected consequences, as 'id' is pretty 
generic for the statement guids, and we would also now be excluding the target 
ID for statements when they are added etc.
  
  This will need some slight refactoring in EntityContent and related classes, 
we need a customizable way (that is efficient) per entity type.

TASK DETAIL
  https://phabricator.wikimedia.org/T205254

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: matej_suchanek, Daimona, Lea_Lacroix_WMDE, Lydia_Pintscher, gerritbot, 
Aklapper, Addshore, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to