daniel added a comment.
@ArielGlenn Hey Ariel! Can you make a patch? Then I'll merge it. It's a one line fix, line 339 in XmlDumpWriter. If I make the patch, it may take a while to find someone to merge it. I don't have strong feelings about this case in particular, and we should go with your preference - at least in my mind, you are the de-facto product owner of the dumps. But I'd like to share a some thoughts about compatibility in general: I think we should generally feel free to break consumers that make unwarranted assumptions, at least in cases where a clear specification exists that explicitly defines the guarantees. A contract that gives guarantees to callers/consumers also defines the freedoms we have in changing behavior and output. Making use of that freedom preserves it. Working around brittle consumers causes complexity and inflexibility on our side. It also seems to me that making output elements optional unnecessarily makes life harder for everyone. Every option is another code path to implement, another default to get right, for the consumers and the producer. We should consider making fewer things optional in new versions of the dump format. TASK DETAIL https://phabricator.wikimedia.org/T174031 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: gerritbot, ArielGlenn, Fjalapeno, Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, WDoranWMF, EvanProdromou, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Pchelolo, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
