daniel added a comment. @aaron I'm afraid that patch doesn't address the actual problem: yes, you can get around the serialization update if you rely on global state. But if you do that, you don't need an extra wrapper thingy, just do it in the DataUpdate.
Note that Wikibase will no longer put DataUpdates into the ParserOutput once I93f09dc5b is merged, see https://phabricator.wikimedia.org/T86308. Maybe it's best to just remove the DataUpdates functionality from ParserOutput alltogether. The LinksUpdate thing can go into AbstractContent::getSecondaryDataUpdates(). ParserOutput::getSecondaryDataUpdates() isn't used anywhere directly, as far as I can see. If we do that, we may want to add a hook to AbstractContent::getSecondaryDataUpdates(). TASK DETAIL https://phabricator.wikimedia.org/T86305 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, daniel, aude, hoo, Lydia_Pintscher, aaron, ori, Jackmcbarn, Anomie, cscott, Wikidata-bugs, Jdforrester-WMF, Legoktm _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
