Smalyshev added a comment.

  > would an index of some sort be needed in order to support something like 
mw.wikibase.getEntity( 'File:Blah.png' )
  
  You'd have to just access page table to look up page by title, then go to the 
appropriate revision & slot (AFAIR there are services already in Wikibase that 
do that) and load the Wikibase data from there. I don't think you'd need 
anything beyond existing page-revision-slot-text tables.
  
  > MediaInfo entities are *currently* the filepage ID but almost none of the 
code assumes that
  
  AFAIR the code that does lookups and title/entityId conversions assumes that. 
Of course that code can be changed, but with this large change it would be 
natural to expect that. I would tend to write such change as YAGNI, but I think 
using standard lookup interfaces which go from Title to EntityId and then load 
the data would allow to avoid hardcoding for this particular use case, and if 
anything changes, these lookups would have to be changed.

TASK DETAIL
  https://phabricator.wikimedia.org/T223792

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: MarkTraceur, Yann, Addshore, Smalyshev, Mholloway, matthiasmullie, 
Multichill, Marsupium, Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jarekt, 
darthmon_wmde, Nandana, JKSTNK, Sario528, Lahi, PDrouin-WMF, Gq86, 
E1presidente, Ramsey-WMF, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, 
Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, 
Morgankevinj, Susannaanas, Jane023, Wikidata-bugs, Base, aude, Ricordisamoa, 
Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to