Ladsgroup added a comment.
In T224189#5398714 <https://phabricator.wikimedia.org/T224189#5398714>, @alaa_wmde wrote: >> One quite expensive way to do this is to define CommonsMedia value type, inject the thumbsize in the value type (by defining CommonsMediaValueParser that takes ParserOptions) and then use it in the CommonsInlineImageFormatter, that would be two days of work at least. Unless I'm missing something obvious. > > Is it only expensive in terms of development time? if so, two days are not all that expensive given that this solution will probably avoid other less ideal workarounds + it is a bit of good refactoring. It can be more than two days, I would say at least, not to mention the review and other bits. Plus I'm not sure it's conceptually correct. For monolignual text, the language code is part of that value. It makes sense but for commons media value type, I don't think its thumb size would be a good fit for the value. TASK DETAIL https://phabricator.wikimedia.org/T224189 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: alaa_wmde, WMDE-leszek, Ladsgroup, hoo, Lydia_Pintscher, Aklapper, Multichill, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Jony, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Prisshahlla, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, V4switch, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, LNDDYL, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
