Michael added a comment.

  Yes, we had a good experience with this as EntitySchema. Do note, that in 
these pre-commit hooks, we did not use grunt 
<https://github.com/wikimedia/mediawiki-extensions-EntitySchema/blob/master/package.json#L22>,
 but the linters directly. The reason is that you cannot give files as CLI 
arguments to grunt and lint-staged is designed to only run the linting on the 
staged files.
  This is basically option 1 of what you mentioned with an added `git add` 
where possible.
  
  I found that approach helpful and would recommend it, even so it is not 
without edge-cases that need to be handled.

TASK DETAIL
  https://phabricator.wikimedia.org/T228734

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Michael, Tarrow, noarave, Rosalie_WMDE, Addshore, 
Aklapper, alaa_wmde, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to