Maxlath added a comment.

  @Addshore it could apply to any image, not just `wdqs-frontend:`: when 
pulling `wikibase/wikibase:1.33-bundle` the name tells me it was built from the 
wikibase/1.33 folder, but that folder has been modified several times:
  
    * 531fbda - (10 weeks ago) More cleanups for performance, use better names 
and passwords - Amir Sarabadani
    * a294b27 - (10 weeks ago) Use a commit that works for 1.33 - Amir 
Sarabadani
    * 7e8697d - (2 months ago) Explicitly download 1.34-wmf.8 of EntitySchema 
for 1.33 bundle - Amir Sarabadani
    * 562e69b - (2 months ago) Add 1.33 + EntitySchema extension - Amir 
Sarabadani
  
  How can I know at which commit it was built?
  
  A solution could be to tag builds with the current commit hash:
  
    TAG=$(git rev-parse HEAD | cut -c 1-7)
    docker build -t wikibase:$TAG -t wikibase:latest
  
  As for archives fetched within Dockerfiles, using `git clone  --depth=1 
https://repo.url` instead of downloading a zip file seems perfectly fine to me: 
that would download only the objects necessary for the last commit, making it 
super fast (actually faster that downloading+unzipping the archive in my test, 
but that was on a small repo with a good connection, maybe that's different for 
bigger repos), and making that last commit hash easy to identify with `git log`

TASK DETAIL
  https://phabricator.wikimedia.org/T231128

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maxlath
Cc: Maxlath, Addshore, Aklapper, darthmon_wmde, Jelabra, DannyS712, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to