Daimona added a comment.

  AFAICS, mTitle is not defined as property, and this happens as of 
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CirrusSearch/+/531450/
  
  IMHO, it's pretty sad that:
  
  - This wasn't spotted when updating the class;
  - Nothing triggered (PHPUnit) tests in WBLCS in the last month, and hence the 
error remained unnoticed;
  - Phan wouldn't have caught it anyway, because we use stubs.
  
  That's a failure across the board... I'm going to fix the code itself, and 
make phan more powerful. And, as a side note, it'd be great to automatically 
run tests in a repo when no changes were sent in say the last month.

TASK DETAIL
  https://phabricator.wikimedia.org/T233763

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, mmodell, Smalyshev, VIGNERON, ArthurPSmith, Lea_Lacroix_WMDE, 
Lydia_Pintscher, Aklapper, Denny, darthmon_wmde, DannyS712, Nandana, 
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, 
Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to