[Wikidata-bugs] [Maniphest] [Updated] T234829: Exception when trying to set claim via the API

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Hm, this exception is thrown in the case of:
  
    if ( !is_array( $serialization ) || !array_key_exists( 'type', 
$serialization ) ) {
        throw new MissingTypeException();
    }
  
  But I would assume calls to `deserialize()` should be guarded at some point 
by `isSerializerFor()`:
  
    public function isDeserializerFor( $serialization ) {
        return is_array( $serialization )
            && array_key_exists( 'type', $serialization )
            && $this->isValidStatementType( $serialization['type'] );
    }
  
  So I’m not sure what’s happening here.
  
  But anyways – I proposed removing the `'type'` altogether in T230117: Remove 
type: statement from JSON serialization of statements 
<https://phabricator.wikimedia.org/T230117>, so that would presumably also 
resolve whatever this issue is.

TASK DETAIL
  https://phabricator.wikimedia.org/T234829

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Ladsgroup, Michael, darthmon_wmde, 
DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Jdforrester-WMF, Mbch331, Jay8g, Krenair

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs