Tgr added a comment.

  In T231084#5554961 <https://phabricator.wikimedia.org/T231084#5554961>, @Tgr 
wrote:
  
  > From a distance, the simple solution would be to create a UserPageError 
subclass describing the situation and throw that instead of the assertion error.
  
  One thing to keep in mind though is that the slot diff renderers are 
low-level code which is invoked in all kinds of contexts, not just diff pages. 
Sometimes in contexts where replacing the diff with an error message would be 
much better than killing the request altogether.
  
  Still, it seems strictly less bad than the current behavior.

TASK DETAIL
  https://phabricator.wikimedia.org/T231084

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tgr
Cc: Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE, Aklapper, zeljkofilipin, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Jdforrester-WMF, 
Mbch331, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to