thiemowmde added subscribers: Lucas_Werkmeister_WMDE, WMDE-leszek, thiemowmde. thiemowmde added a comment.
Note: I was the driving force when we introduced the WikibaseCodeSniffer rule set. The main motivations back then: 1. Being able to experiment with additional, custom sniffs that neither exist in the MediaWiki nor the PHPCS rulesets. However, a bunch of these custom sniffs became obsolete by now, or have been incorporated into the MediaWiki ruleset. There are a few custom sniffs left. I'm not sure if the value created by these extra sniffs is big enough to justify having the WikibaseCodeSniffer codebase. 2. Being able to enable additional sniffs by default for all Wikibase codebases, without the need to repeat the configuration in every .phpcs.xml file. 3. Being able to get rid of some of the less valuable MediaWiki rules in all Wikibase codebases, without the need to repeat configuration. The motivation for each exception is documented in https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml. If the current Wikidata team(s) don't find any of this valuable any more, they should feel free to ditch the WikibaseCodeSniffer and use the #mediawiki-codesniffer <https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/> directly. TASK DETAIL https://phabricator.wikimedia.org/T243296 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, WMDE-leszek, Lucas_Werkmeister_WMDE, Daimona, Ladsgroup, Jdforrester-WMF, Aklapper, MaxSem, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g, Legoktm
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs