thiemowmde added a project: Patch-For-Review.
thiemowmde added a subscriber: Jc3s5h.
thiemowmde added a comment.

As far as I can tell, we do not do any conversion (at least not since the 
JavaScript backend was dropped in favor of API calls). What the user enters is 
stored. When you change the calendar model, the date is not converted. This is 
intended, as far as I'm aware of.

I see two problems, at the moment:

1. The documentation in the TimeValue class is wrong. This is confusing but 
doesn't cause direct harm because this class doesn't do anything with this 
information. In fact, the interpretation of the timestamp and the calendar 
model should probably not be documented in this class at all.
2. The diff view currently assumes the timestamp is always Gregorian (fixed in 
https://github.com/DataValues/Time/pull/32).

I fail to understand what the users (e.g. @Jc3s5h) in 
https://phabricator.wikimedia.org/T87312 are talking about. It seems they are 
expecting conversion but don't give enough detail when and how that should 
happen.


TASK DETAIL
  https://phabricator.wikimedia.org/T88437

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: Jc3s5h, Accurimbono, Candalua, thiemowmde, Lydia_Pintscher, Tobi_WMDE_SW, 
JulesWinnfield-hu, Addshore, Aklapper, Liuxinyu970226, Wikidata-bugs, aude



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to