Addshore added a comment.
Another option would be something like:
$de = $contentHandler->createDifferenceEngine(
$form->getContext(),
$rev1,
$rev2,
null, // rcid
( $data['Action'] == 'purge' ),
( $data['Unhide'] == '1' )
);
if(!$de->canDiffRevisions();){
// Throw special page error here
}
$de->showDiffPage( true );
With canDiffRevisions being implemented in DifferenceEngine which would see
if the 2 contents say they can be diffed with each other?
I mean, when would it ever make sense to even try and diff wikitext and a
wikibase entity?
TASK DETAIL
https://phabricator.wikimedia.org/T231084
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: Addshore, Umherirrender, Ladsgroup, Tgr, Michael, Lucas_Werkmeister_WMDE,
Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden,
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude,
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
