Addshore added a comment.
In T237164#5889530 <https://phabricator.wikimedia.org/T237164#5889530>, @thiemowmde wrote: > Wasn't this what @MaxSem tried already in https://gerrit.wikimedia.org/r/547911? Yes it looks like it, and that seemed to pass CI > What's the point of this library anyway? A shared test base and set of tests for a shared interface shared between multiple projects. It includes tests for all of the basic functionality and spec of the PSR, making sure implementations are doing the right things. > As far as I can tell it's used in a single (!) file: SimpleCacheWithBagOStuffTest. Yes > What does it do? Runs more tests > What do we loose when we get rid of the library? A bit of coverage maybe? Can't we restore this coverage by writing a few more test cases, without relying on the external library? We either: - choose to have less coverage - copy and paste the test cases into our own code and have the same coverage - send time writing other different tests probably resulting in the same or less coverage > Or even better, aren't the existing test cases enough to cover the code? Probably not, we only test a few very specific cases on top of what is provided by the base tests TASK DETAIL https://phabricator.wikimedia.org/T237164 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Rosalie_WMDE, Addshore Cc: Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Iflorez, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
