Lucas_Werkmeister_WMDE added a comment.
> On Special:EntityData, anything that has argument just passes through Varnish/ATS. So format=foo, revid=666, etc. All see the uncached version Are you //sure// about this? Because basically all of T217897: Reduce / remove the aggessive cache busting behaviour of wdqs-updater <https://phabricator.wikimedia.org/T217897> hinges on the fact that requests for a specific revision //can// be cached in Varnish (we didn’t use ATS at the time). And I’m getting a cache hit: $ curl -svo/dev/null https://www.wikidata.org/wiki/Special:EntityData/Q1.ttl?revision=1116941900 2>&1 | grep -i '^< x-cache' < x-cache: cp3052 miss, cp3052 hit/3 < x-cache-status: hit-front > We support too many formats but why not just cache invalidating of ttl of json for now? for Special:EntityData/Q666.json and Special:EntityData/Q666.ttl It's just two lines of code. Well, I’d prefer to “do the right thing”, and not just invalidate the formats that happen to be requested most often. If we can afford to do this. > If we cache them we should purge them. But I'm worried about the performance implications of sending a purge for every possible combination of parameters. So how many combinations do we actually have? - **5** formats, see documentation <https://www.mediawiki.org/wiki/Wikibase/EntityData>. (`.html` doesn’t count, that’s a redirect.) Down to four formats if we go ahead with T98035: [Task] Drop support for php-serialized output from Special:EntityData <https://phabricator.wikimedia.org/T98035>. - **4** flavors: “simple”, “dump”, “long”, “full” (default). I think that’s all the variables, so that’s **20** URLs we would need to purge. Is that enough to be a problem? TASK DETAIL https://phabricator.wikimedia.org/T128486 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Ladsgroup, Addshore, Pablo-WMDE, WMDE-leszek, Lucas_Werkmeister_WMDE, hoo, daniel, ori, Legoktm, mkroetzsch, Smalyshev, Aklapper, StudiesWorld, Lydia_Pintscher, Sarai-WMDE, darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
