Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Bridge-Sprint-15.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  After the Bridge has successfully saved, we want to reload the page instead 
of closing the dialog, so that users will see the updated information.
  
  This happens in the init module (see `subscribeToEvents`). The app already 
emits different events for save vs. cancel, no change should be necessary there.
  
  A simple location.reload() 
<https://developer.mozilla.org/en-US/docs/Web/API/Location/reload> should be 
fine.
  
  Note: it’s possible that some other code will block the reload via the 
onbeforeunload event 
<https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload>,
 e. g. to warn of unsaved changes being lost. This is acceptable – if the other 
code thinks the window shouldn’t be reloaded without warning, we should not 
reload it.

TASK DETAIL
  https://phabricator.wikimedia.org/T246219

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to