Addshore created this task. Addshore added projects: Wikidata, wikidata-tech-focus, User-Addshore, Lexicographical data, WikibaseMediaInfo.
TASK DESCRIPTION Lexeme has code such as this in its entity type wiring. 'entity-revision-lookup-factory-callback' => function ( EntityRevisionLookup $defaultLookup ) { return new FormRevisionLookup( $defaultLookup ); }, $defaultLookup here is conveniently a WikiPageEntityRevisionLookup. This default lookup should probably be removed and each entity type that requires a WikiPageEntityRevisionLookup should instead grab one in its own wiring. Currently WikiPageEntityRevisionLookup is only created in SingleEntitySourceServices in getEntityRevisionLookup Instead a WikiPageEntityRevisionLookupFactory should be retrievable from somewhere in data-access as a generic service. Entity type definitions should then specify the WikiPageEntityRevisionLookupFactory or closure that can be used to retrieve an WikiPageEntityRevisionLookup for them. This standard factory is probably needed as the database name needs to be passed in from the entity source once that is known further up the wiring tree. TASK DETAIL https://phabricator.wikimedia.org/T246451 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Tarrow, Addshore, darthmon_wmde, Nandana, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs