Charlie_WMDE moved this task from Verification to To do on the Wikidata-Bridge-Sprint-16 board. Charlie_WMDE added a comment.
Hello, as mentioned in the daily, the license banner is currently scrollable. Although I failed to mention it in the ACs we would like it to be sticky and "above" the Bridge UI in a sense. two spec things i noticed: 1. header has extra padding that shouldn't be there the 8px and 2.5....px are both not needed. The top should just touch the 16px margin we have going around everything, and the first paragraph already has a 8px margin to the top which is all that's needed. F31686719: Screenshot_20200317_114543.png <https://phabricator.wikimedia.org/F31686719> F31686718: Screenshot_20200317_114614.png <https://phabricator.wikimedia.org/F31686718> 2. the last paragraph has an extra 8px margin. this is not needed either. it should just touch the 16px margin that goes around the whole banner. F31686725: Screenshot_20200317_114634.png <https://phabricator.wikimedia.org/F31686725> F31686724: Screenshot_20200317_114650.png <https://phabricator.wikimedia.org/F31686724> specs for reference F31686729: Banner_License_withoutCheckbox.png <https://phabricator.wikimedia.org/F31686729> TASK DETAIL https://phabricator.wikimedia.org/T238728 WORKBOARD https://phabricator.wikimedia.org/project/board/4631/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Addshore, Pablo-WMDE, Lucas_Werkmeister_WMDE, Charlie_WMDE, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, Sarai-WMDE, darthmon_wmde, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
