Addshore added a comment.
So we just had a little discussion and determined that 2 issues have now been identified here: 1. as described in this ticket, CachingPrefetchingTermLookup does not work with getLocalServerObjectCache returns an EmptyBagOStuff, as the Lookup expects to be able to store knowledge there in every case. 2. also CachingPrefetchingTermLookup expects that callers to methods of of the TermLookup interface have already called prefetchTerms which is not the currently expected situation in Wikibase. The actionables that we came to from the discussion are: - CachingPrefetchingTermLookup should contain a second internal cache that wraps the external one ie. not loose information in the case no local cache is available - Document the implementations of PrefetchingTermLookup and TermLookup methods stating where they will be retrieving data from, and what the fallbacks are @Ladsgroup @Jakob_WMDE @Tarrow Sorry this took so long to write, I hope my memory served me correctly... TASK DETAIL https://phabricator.wikimedia.org/T247196 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Addshore Cc: WMDE-leszek, Jakob_WMDE, Tarrow, Samantha_Alipio_WMDE, Addshore, Aklapper, CXuesong, Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wong128hk, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
