Lucas_Werkmeister_WMDE added a comment.

  Yes, mainly this – current line-height is 1.5, Figma says 1.6, unclear if 
that should be changed in this task or the already existing follow-up:
  
  In T249121#6019944 <https://phabricator.wikimedia.org/T249121#6019944>, 
@Lucas_Werkmeister_WMDE wrote:
  
  > @Charlie_WMDE Figma specifies 1.6 line-height, but currently the 
`IconMessageBox` has 1.5 line-height (story 
<https://doc.wikimedia.org/Wikibase/master/js/data-bridge-storybook/?path=/story/iconmessagebox--notice-long>).
 Should we fix that here, or leave it for later with the rest of T246117: 
Improvement: Increase line-height of 14px font to 1.6 (22px) 
<https://phabricator.wikimedia.org/T246117>?
  > (Technically, it currently shares the same styles as other “body S” 
components, so fixing the line-height only for `IconMessageBox` would be a bit 
annoying to implement.)

TASK DETAIL
  https://phabricator.wikimedia.org/T249121

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Charlie_WMDE, Aklapper, Pablo-WMDE, Sarai-WMDE, darthmon_wmde, Michael, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to