daniel created this task. daniel added projects: Wikidata, Wikidata-Campsite.
TASK DESCRIPTION Wikibase uses the LoadExtensionSchemaUpdates hook for database schema updates. Handlers of this hook must not modify the database directly, but mist instead register updates for later execution. Wikibase does apply modifications directly in: - /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/ChangesSubscriptionSchemaUpdater.php:48 - /workspace/src/extensions/Wikibase/repo/includes/Store/Sql/DatabaseSchemaUpdater.php:78 This can lead to database corruption in production, see T157651 <https://phabricator.wikimedia.org/T157651>. There is a structure test up for review to prevent this kind of mistake: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475065. However, it cannot be merged until Wikibase is fixed. TASK DETAIL https://phabricator.wikimedia.org/T249598 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: Aklapper, Krinkle, kchapman, Pablo-WMDE, Ladsgroup, alaa_wmde, Anomie, Addshore, WMDE-leszek, kostajh, daniel, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
