Addshore added a comment.

  I went and looked through the code and it doesn't look like anything has 
changed here in the last years regarding the entity lookup and revision 
resolving specifically for LUA.
  
  It looks like this perhaps happened with T196882 
<https://phabricator.wikimedia.org/T196882> and or T229280 
<https://phabricator.wikimedia.org/T229280>
  
  > Having some regression test would be good.
  
  There already is for the bits of code touched in the 2 linked ticket, 
although not an integration or e2e test for the high level LUA integration.
  
  > Note the inconsistency between getLabel and getLabelByLang.
  
  IT might be worth popping that in another ticket!

TASK DETAIL
  https://phabricator.wikimedia.org/T157868

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Vriullop, Tomukas, Mike_Peel, RexxS, Bugreporter, Ahecht, 
Dipsacus_fullonum, eranroz, Uzume, Salgo60, Larske, hoo, matej_suchanek, 
Aklapper, darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to