Addshore added a comment.
So we did a task break down related to this ticket (although the immediate
issue described in this ticket has already been fixed).
The rough breakdown below should move the prefetching of data for federated
properties to before "any" (perhaps) data is used.
- Move the code from SingleEntitySourceServices::getEntityInfoBuilder into
the entity type wiring files
- Alter FullEntityParserOutput::getParserOutput to call getEntityInfo earlier
and always (Need to think and check this is okay...) (See Fig1)
- Need to figure out what makes the calls to get parser output without
getting the HTML?
- And how much this code path is called
- And what the alter in logic might do?
- TODO investigate what this entity info lookup is still used for etc...
(Might be leftover from https://phabricator.wikimedia.org/project/view/3407/ ? )
- Implement an EntityInfoBuilder for federated properties that prefetches
$entityIds using the ApiEntityLookup
- Override the EntityInfoBuilder for federated properties to do the
prefetching
Fig1.
F31841545: image.png <https://phabricator.wikimedia.org/F31841545>
The prefetching for other cases such as the history page should already be
covered in
LanguageFallbackLabelDescriptionLookupFactory::newLabelDescriptionLookup which
does a `prefetchTerms` using a `termBuffer`.
However looking at ItemHandler::getActionOverrides, the
newLabelDescriptionLookup call which would allow the prefetching currently
doesn't pass in any entity ids so maybe this doesn't happen?
TODO figure this out? This probably doesn't happen on Wikidata either that
means? but should it? because of the now used terms caching stuff?
TASK DETAIL
https://phabricator.wikimedia.org/T253125
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Addshore
Cc: RhinosF1, Aklapper, Addshore, Jimfhahn, darthmon_wmde, Nandana, lucamauri,
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper,
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
