Addshore added a comment.
When trying to remove things I ran into an issue with FullEntityParserOutputGeneratorTest.php::testGetParserOutputIncludesLabelsOfRedirectEntity It seems some of the stuff in T96553 <https://phabricator.wikimedia.org/T96553> is related. It seems the old EntityInfo based lookup stuff is used in this integration test, (even if it is not used in production). The situation being tested is... - Q1 redirects to Q2. - Q2 has a label of "foo" - Q3 has a statement using Q1 as a value - The expected behaviour is that the value uses the label from Q2 (redirect target) even though the value on the entity is still Q1 Checking on test.wikidata.org this is currently the case https://test.wikidata.org/wiki/Q212354 Checking locally (with the patch removing entityinfo from view classes) this is also the case... just the test is evil? TASK DETAIL https://phabricator.wikimedia.org/T254283 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Jakob_WMDE, Addshore, Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, Pablo-WMDE, GoranSMilovanovic, Adik2382, Jayprakash12345, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
