Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Extension Decoupling and Registration. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION Currently, `CachingCommonsMediaFileNameLookup` passes keys (concatenated in `getCacheKey()`) directly into `BagOStuff` methods, without using any `make*Key()` method. This isn’t ideal; it should probably use `makeKey()`. That said, the impact of this is limited since it looks like `CachingCommonsMediaFileNameLookup` is only instantiated with a `HashBagOStuff` (in `WikibaseRepo::getCachingCommonsMediaFileNameLookup()`), so the key isn’t used beyond that one cache instance anyways. See also T255116 <https://phabricator.wikimedia.org/T255116> for the investigation that led to the creation of this task. TASK DETAIL https://phabricator.wikimedia.org/T256016 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
