Michael moved this task from in progress to ready to go on the Wikidata board. Michael changed the task status from "Open" to "Stalled". Michael added a comment.
The reasons that the tests break is because of patch ebe58f <https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/ebe58f9f11d4bc7b7c1790726ad85e99b61e37ce> (Ic8d5a66 <https://gerrit.wikimedia.org/r/#/q/Ic8d5a66b5737532ed0591de599d9464882b3c931>) which was made to fix T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with <https://phabricator.wikimedia.org/T245396>. However, as `SimpleCacheWithBagOStuff` is not a `BagOStuff`, but a PSR-16 Simple Cache <https://www.php-fig.org/psr/psr-16/>, so this patch broke its contract and now the tests fail. To reintroduce the assertions, we first need to fix the root cause that lead to all those production errors. That seems to be T250930: Wikibase receiving ⧼Lang⧽ from uselang parameter and using it everwhere <https://phabricator.wikimedia.org/T250930>. After proper handling/santizing of lang is implemented, we maybe should also have a look at other potentially strange callers ( T246207: Track down unusual callers to SimpleCacheWithBagOfStuff <https://phabricator.wikimedia.org/T246207> ). Afterwards, we can unstall this ticket. A first step could be to reintroduce the assertions as warnings, so that we find and fix possible stray errors, before we actually introduce the exceptions again and mend the contract. TASK DETAIL https://phabricator.wikimedia.org/T237164 WORKBOARD https://phabricator.wikimedia.org/project/board/71/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: WMDE-leszek, Lydia_Pintscher, Rosalie_WMDE, Addshore, Daimona, Jdforrester-WMF, Ladsgroup, thiemowmde, Aklapper, MaxSem, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
