Lucas_Werkmeister_WMDE created this task. Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Extension Decoupling and Registration (Sprint 2). Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION As part of the effort to move WikibaseClient to extension registration, we stopped loading `$wgWBClientSettings` in the PHP entry point (`WikibaseClient.php`) – instead, the default settings are loaded (and merged with the custom settings) at a later time, in the `WikibaseSettings` class. However, we forgot about the `Settings` class (`\Wikibase\Lib\Settings`), which is a kind of duplicate settings system, separate from `WikibaseSettings` (deprecated a while ago, two remaining users). This class still directly accesses the `$wgWBClientSettings` global, so now it’s missing all the default settings. The proper solution for that, we believe, is to move the remaining two users of this class to `WikibaseSettings`, and then to get rid of the class. (Note that for the parent task, to unblock the train, we’re going with the simpler solution of reverting the change that stopped loading `$wgWBClientSettings` in `WikibaseClient.php`.) TASK DETAIL https://phabricator.wikimedia.org/T257334 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
