Lucas_Werkmeister_WMDE added a comment.

  I think the best solution to this is to just remove the whole example repo 
from `WikibaseClient.example.php` – or, more likely, to wrap it in `if ( false 
)` instead of `if ( !defined( 'WB_NO_CONFIGURE_EXAMPLE_REPO' ) )`, just like 
the already existing block for a `$wgLBFactoryConf` which is also disabled with 
`if ( false )`.
  
  Whether this affects any end users depends on how the example files are 
typically used, I suppose. The configured example repo isn’t very useful as a 
whole: the repo URL is http://repo.example.org. But it’s possible that people 
are loading the example settings and then only overriding the repo URL while 
keeping, say, the repo article path and script path.
  
  But I think that should be tractable with an announcement to the 
wikidata-tech mailing list, informing users that if they have a client wiki 
that’s not also a repo, they may need to update their configuration. (I assume 
most wikibase clients are also repos – wikibase-docker, in particular, only 
supports this mode as far as I’m aware.)
  
  (Wikimedia production should be unaffected anyways, as we don’t use the 
example settings at all there.)

TASK DETAIL
  https://phabricator.wikimedia.org/T257449

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tarrow, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to