Michael created this task. Michael added projects: Wikidata-Campsite, wikidata-tech-focus, Wikidata. Restricted Application added a subscriber: Aklapper.
TASK DESCRIPTION The `MatchingTermsLookup` interface <https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/includes/Store/MatchingTermsLookup.php#L44> states: /** * Returns the terms that match the provided conditions ranked with the 'most important' / top first. * Will only return one TermIndexEntry per Entity * * [...] */ public function getTopMatchingTerms( [...] However, the new implementation in `DatabaseMatchingTermsLookup` only consists out of: /** * @inheritDoc */ public function getTopMatchingTerms( array $criteria, $termType = null, $entityType = null, array $options = [] ) { // The new term store doesn't support order by weight. return $this->getMatchingTerms( $criteria, $termType, $entityType, $options ); } It seems that the `Will only return one TermIndexEntry per Entity` part is missing unintentionally. TASK DETAIL https://phabricator.wikimedia.org/T257856 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, guergana.tzatchkova, Ladsgroup, Addshore, Michael, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
