jcrespo added a comment.
> based on that sentence, I would even today vote against the change Amir
just uploaded if it wasn’t for this ticket, because it seems to fly directly in
the face of this documentation: why use $join_conds if the documentation says
it’s unnecessary except for a LEFT JOIN that we don’t want?
That documentation is, IMHO, wrong. And I can bring authoritative references
if needed: implicit joins are not ANSI (aka not real "SQL" standard), and are
deprecated in several database engines ("considered harmful" XD). MySQL keeps
supporting it, as it does with other set of bad practices- and I don't advocate
necessarily to remove the option, but I do to discourage it- again based on
actual past outages that it has caused on Wikimedia by mistaken deploys, as I
mentioned on my initial comment.
TASK DETAIL
https://phabricator.wikimedia.org/T246232
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Ladsgroup, jcrespo
Cc: Lucas_Werkmeister_WMDE, Addshore, Aklapper, Marostegui, Ladsgroup, jcrespo,
Alter-paule, Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez,
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki,
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan,
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen,
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331,
Jay8g
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
