Michael added a comment.
In T253201#6341017 <https://phabricator.wikimedia.org/T253201#6341017>, @99of9 wrote: > In other news, you know testing is going well your code complains about tiny problems with regexes in Wikidata: https://www.wikidata.org/w/index.php?title=Property%3AP6993&type=revision&diff=1240888486&oldid=997662566 Ah, the differences in PHP vs JS regex evaluation! Your edit is fine as it doesn't change what the regex matches, but do note that the regex `[1-9]\d*+(\-[a-z]+)*` is valid/compatible PCRE, which seems to be the relevant standard for P1793 <https://www.wikidata.org/wiki/Property:P1793>. I wonder if having a requirement that those regexes must be both valid PCRE and work in ECMAScript would be sensible? 🤔 TASK DETAIL https://phabricator.wikimedia.org/T253201 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: 99of9, Michael Cc: Michael, Moebeus, Tarrow, 99of9, Aklapper, Lydia_Pintscher, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
