[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given

[Catrope]

Catrope added a comment.


  The relevant code is
  
                $layout->appendContent(
                        ...$this->getCaptionsContent(
                                $entity->getLabels(),
                                $this->getLanguagesOrderedByFallbackChain( 
$entity )
                        )
                );
  
  I think the simplest fix would be to simply remove the spread operator 
(`...`), since `appendContent()` can also be called with an array as the only 
parameter.

TASK DETAIL
  https://phabricator.wikimedia.org/T259744

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Catrope
Cc: Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, 
Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, 
SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, 
Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, 
Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs