daniel added a comment.

From looking at the code in UsageUpdater, SqlUsageTracker, and 
UsageTableUpdater, it seems like this should not happen, since the check 
against existing entries in the database is done in the same "atomic section" 
(aka transaction) as the insert. However, since MW's database abstzraction 
doesn't make any hard guaranteed about transactional integrity, I'll change the 
implementation of UsageTableUpdater::addUsageForPage to ignore duplicate rows. 
This is compliant with the intended semantics of "after adding X, X should be 
in the table, no matter if it was already there before".


TASK DETAIL
  https://phabricator.wikimedia.org/T90405

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
<username>.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: aude, daniel, Aklapper, hoo, Wikidata-bugs, Jdouglas



_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to