Pablo-WMDE added a comment.
As this comment <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/fd9769f/repo/includes/Content/EntityContent.php#356> correctly says, not all entities have a concept of what Labels are - it just so happens that all entities types in core wikibase (items, properties) have them. There are already dedicated `EntityContent` implementations for items & properties (`ItemContent` & `PropertyContent` respectively - they should use a way of de-duplicating the relevant code (e.g. traits) without making false assumptions. Lexeme's LexemeContent <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseLexeme/+/df62449/src/MediaWiki/Content/LexemeContent.php> should gain a correct implementation. MediaInfo's MediaInfoContent <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseMediaInfo/+/c50245e/src/Content/MediaInfoContent.php> has to implement the method the way it is correct for it (currently it returns empty string there, which is probably a good enough value as far as camp is concerned). TASK DETAIL https://phabricator.wikimedia.org/T263435 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Lydia_Pintscher, darthmon_wmde, abian, Akuckartz, Iflorez, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
