Pablo-WMDE added a comment.
> I think it would be helpful to see how several of the components can be combined Agree. That, in my eyes, could be the job of dedicated stories. I see this happening eventually once it becomes more relevant with the advent of more components. > I am also unsure about the code shown Agree. I think the vehicle of "Show code" and its placement makes sense, but what it shows could be reduced to avoid confusion (cf. 1 <https://stackoverflow.com/questions/62880900/show-templates-code-with-storybook-addon-docs>). tl;dr only the `template` bit is relevant. I don't feel like I'm in a position to file a ticket to request changes around that but it would make sense to me. > I think also here it would be good to have an example of using tokens. What you mean is clear but any concrete example exhibits the problem that it would showcase (and thus, arguably, favor) the use of one particular technology - while the documentation so far intentionally tries to avoid that: the tokens are shipped in multiple formats (less, sass, css, json) exactly to enable users of all technologies alike. I actually once created a commit <https://github.com/wmde/wikit/commit/074571e350a1a7e27c3b2646571655aca434cc84> to be a bit more helpful without pushing a particular tech - but it never saw the light of day. Do you think it would be helpful at all/a step in the right direction? TASK DETAIL https://phabricator.wikimedia.org/T264733 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Jan_Dittrich, Tonina_Zhelyazkova_WMDE, Aklapper, Sarai-WMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
