toan added a comment.

  Ok, so after looking at this yesterday and today I've tried to replicate my 
local environment to what has been and what currently is deployed on 
https://de.wikivoyage.org/wiki/Spezial:Version
  
  LuaSandbox    3.0.3
  Lua           5.1.5
  
  Installing luasandbox for mediawiki-docker-dev with the following command.
  
    apt-get install liblua5.1-0-dev
    
    git clone https://gerrit.wikimedia.org/r/mediawiki/php/luasandbox.git
    
    phpize && ./configure && make && sudo make install
    
    # add this extension=luasandbox.so
    nano /opt/docker/etc/php/php.ini
    
    service php-fpm restart
  
  In Scribunto Enginge.php comment out the following to get the function 
profile on line 71
  
                #if ( $t < 1.0 ) {
                #       return $ret;
                #}
  
  rolling my development environment back to `1.36.0-wmf.8` for Wikibase, core, 
Scribunto
  
  using a simple module such as
  
    local p = {} --p stands for package
    
    function p.testAddStatementUsage( frame, entityID, property )
    
        return mw.wikibase.getBestStatements ( 'Q1', 'P1' )
    end
    
    return p
  
  addStatementUsage is only called once and the profile returns the following
  
    <!-- 
    NewPP limit report
    Parsed by mediawiki.mw.localhost
    Cached time: 20201021122924
    Cache expiry: 86400
    Dynamic content: false
    Complications: []
    CPU time usage: 0.032 seconds
    Real time usage: 0.033 seconds
    Preprocessor visited node count: 5/1000000
    Post‐expand include size: 10/2097152 bytes
    Template argument size: 0/2097152 bytes
    Highest expansion depth: 2/40
    Expensive parser function count: 0/100
    Unstrip recursion depth: 0/20
    Unstrip post‐expand size: 0/5000000 bytes
    Lua time usage: 0.013/10.000 seconds
    Lua memory usage: 525 KB/50 MB
    Lua Profile:
        Scribunto_LuaSandboxCallback::getEntityStatements                 20 ms 
     100.0%
    Number of Wikibase entities loaded: 1/250
    -->
    <!--
    Transclusion expansion time report (%,ms,calls,template)
    100.00%    0.000      1 -total
    -->
  
  Running it a couple of times `Lua time usage` seems vary between `0.011 - 
0.014`
  
  Moving forward to `1.36.0-wmf.13` on Wikibase, core, Scribunto
  
  I'm running the same script and now getting the following results.
  
    <!-- 
    NewPP limit report
    Parsed by mediawiki.mw.localhost
    Cached time: 20201021124843
    Cache expiry: 86400
    Dynamic content: false
    Complications: []
    CPU time usage: 0.046 seconds
    Real time usage: 0.048 seconds
    Preprocessor visited node count: 5/1000000
    Post‐expand include size: 10/2097152 bytes
    Template argument size: 0/2097152 bytes
    Highest expansion depth: 2/40
    Expensive parser function count: 0/100
    Unstrip recursion depth: 0/20
    Unstrip post‐expand size: 0/5000000 bytes
    Lua time usage: 0.024/10.000 seconds
    Lua memory usage: 526 KB/50 MB
    Lua Profile:
        Scribunto_LuaSandboxCallback::getEntityStatements                 20 ms 
     100.0%
    Number of Wikibase entities loaded: 1/250
    -->
    <!--
    Transclusion expansion time report (%,ms,calls,template)
    100.00%    0.000      1 -total
    -->
  
  Running it a couple of times it seems we indeed have an increase in the `Lua 
time usage` running the same scripts varying between `0.022 -  0.024`

TASK DETAIL
  https://phabricator.wikimedia.org/T265562

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, toan, hoo, Lydia_Pintscher, 
RolandUnger, Aklapper, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
lucamauri, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, SundanceRaphael, _jensen, rosalieper, Scott_WUaS, Jonas, Volker_E, 
alex-mashin, Wikidata-bugs, aude, GWicke, Dinoguy1000, jayvdb, MrStradivarius, 
Jackmcbarn, Mbch331, Rxy, Jay8g
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to