Tarrow moved this task from Doing to Peer Review on the Wikidata-Campsite
(Wikidata-Campsite-Iteration-∞) board.
Tarrow added a comment.
I did a quick investigation into the current usages of these caching classes:
Right now `CachingPrefetchingTermLookup` is only instantiated by the wiring
for Property Entities in `lib`. Its cache interface is prefixed with
`wikibase.prefetchingPropertyTermLookup.`
`CachingFallbackLabelDescriptionLookup` is use by:
- the lua bindings here
\Wikibase\Client\DataAccess\Scribunto\Scribunto_LuaWikibaseLibrary::newLanguageDependentLuaBindings
which uses the client formatter cache. This is intentionally prefixed with
`wikibase.repo.formatter.`
- WikibaseValueFormatterBuilders.
- In client this is using the client formatter cache (prefixed with
`wikibase.repo.formatter.`)
- in repo this is using the repo formatter cache (prefixed with
`wikibase.repo.formatter.`)
This means that right now they are not inappropriately sharing the cache and
there is not a risk of collisions. Of course we should be sure not to
accidentally cause collisions when working on T266144
<https://phabricator.wikimedia.org/T266144>
TASK DETAIL
https://phabricator.wikimedia.org/T266141
WORKBOARD
https://phabricator.wikimedia.org/project/board/3539/
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Tarrow
Cc: toan, Aklapper, Lucas_Werkmeister_WMDE, Akuckartz, Iflorez, alaa_wmde,
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
