Krinkle added a comment. This change (Ic416def846f361425c46f7b <https://gerrit.wikimedia.org/r/#/c/193130/>) in general seems fine. However I'd like to see further evidence that the QUnit jenkins job is indeed failing because of this. And as a general practice it seems to me that requesting so many modules in one request means one of two things:
- The relevant software is incorrectly using the ResourceLoader module system. (E.g. using it as a complete class registry.) This has all kinds of scalability impacts and semantic "fragileness" to it that warrants addressing. Take an example after VisualEditor where class and file count is very high, but module count is low. - Software is using overly long module names. It is definitely too naive for ResourceLoader not have a limit by default. However I argue this limit should never be reached. If this limit is reached, we're talking about failure mode / error handling / graceful degradation, not normal modus operandi. I suppose the test is slightly different in that it requests everything at once in a way production never would. A quick check to verify that is the case would be nice. We may want to add a logged check to mediawiki.js asserting the request is shorter. It'd be tolerated in tests (until we find a better way to deal with that). TASK DETAIL https://phabricator.wikimedia.org/T90453 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: JanZerebecki, Krinkle Cc: hashar, Tobi_WMDE_SW, Krinkle, gerritbot, JanZerebecki, Aklapper, Wikidata-bugs, Jdouglas, aude, Jdforrester-WMF, jeremyb-phone, Legoktm _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
