Lucas_Werkmeister_WMDE added a subscriber: Pablo-WMDE. Lucas_Werkmeister_WMDE added a comment.
Task inspection notes: - Idea from @Pablo-WMDE: add some logging to the entity ID generating code (with stack traces or similar), run our browser test suite (or API edge-to-edge tests, or similar), and see if anything unexpected causes entity IDs to be generated. Try to build a comprehensive overview of what causes entity IDs to be generated. - We seem to be in agreement that the “proper” solution to the problem of skipped item IDs would be to only assign an item ID very late, just before saving the item; however, this solution would likely take a lot of effort, since we’d have to adjust a lot of code to remove the assumption that item IDs are always available. (I dimly remember some related problems when editing Forms and Senses, whose IDs below the lexeme ID are also assigned in some different way…) - This doesn’t really belong to the investigation, but assuming that the main cause of skipped item IDs is T264450: Entity ID should not be assigned if rate limit is hit <https://phabricator.wikimedia.org/T264450> (due to T258354: remove noratelimit from bot group for Wikidata <https://phabricator.wikimedia.org/T258354>), I am thinking that one solution might be to introduce a separate rate limit for new item IDs (with the same limit as for page creation, probably), and to check that rate limit right before assigning an ID. This would also, in a way, “protect” us from the other issues – if you send a million new items with label/description conflicts per minute, then now you run into the “new item ID” rate limit before we even check for conflicts. (Could also reuse the same `create` rate limit, not sure.) - Can we confirm if the rate limit (or some other error) is the main cause, by checking which errors are returned most frequently by the API? Maybe we have a dashboard of API errors or something similar. TASK DETAIL https://phabricator.wikimedia.org/T268625 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Pablo-WMDE, Lucas_Werkmeister_WMDE, Lydia_Pintscher, WMDE-leszek, Aklapper, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
