Snaterlicious added subscribers: adrianheine, Snaterlicious. Snaterlicious added a comment.
@adrianheine: Can you join in on that? We need a sane way to pass the configuration which is to be picked up in `wikibase.ui.entityViewInit.js` on to `jQuery.valueview.experts.CommonsMediaType` and `jQuery.ui.commonssuggester` respectively. We could do that just like it is done for the content languages. However, since those options are rather of a static nature, I wonder why such are not just injected into the specific `Expert` prototypes in `wikibase.experts.getStore` instead of passing them down the whole view chain along with the `ValueViewBuilder` as that results in having the options passed to the `Expert` instance currently used by `jQuery.valueview` regardless of whether the `Expert` actually requires the option. Here is some suggestion: How about scraping the underscore from `jQuery.valueview.Expert._options` have those act more like `jQuery.Widget` options and add an option like `url` to `jQuery.valueview.experts.CommonsMediaType` as well as to `jQuery.ui.commonssuggester`. Maybe that option should even default to `null` to get that hard-coded commons URL completely out of there. `CommonsMediaType` would just pass the `url` on to the `commonssuggester`. `CommonsMediaType`'s `url` option default would simply be overwritten in `wikibase.experts.getStore` with the new Wikibase setting. Eventually, the prefix "commons" of those components should probably be replaced. TASK DETAIL https://phabricator.wikimedia.org/T90492 REPLY HANDLER ACTIONS Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign <username>. EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: despens, Snaterlicious Cc: Snaterlicious, adrianheine, Ricordisamoa, gerritbot, daniel, Aklapper, Wikidata-bugs, Jdouglas, aude _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
