Charlie_WMDE added a comment.
Removing or disabling the trashcan is an inconsistent behavior. we'd rather have to find arguments for why we *should* remove or disable it. I couldn't find any. if there's no good reason (preventing the user to make an error for example) to disable/remove the button, then we should keep consistency and let people remove conditions, no matter how many are on the screen. if the user wants to delete the last condition, why stop them? they will always be able to create a new one so we're not maneuvering them into a cul-de-sac. additionally, it might be faster this way than clearing all the fields of the last condition, should they realize that they don't need that input either. the placeholder is already implemented for the empty results section, so should be easy to replicate. Additionally, it is a good practice and a way to get some early feedback on this pattern, since i can foresee us using this on Wikidata as well, on a new item page without statements for example. all this leads me to believe, that from a UX-perspective the button should stay. Hope this makes sense. Happy to explain further if something is unclear. TASK DETAIL https://phabricator.wikimedia.org/T268982 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Charlie_WMDE Cc: Charlie_WMDE, Ladsgroup, Aklapper, Lydia_Pintscher, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
