Tarrow added a comment.
In T273041#6793152 <https://phabricator.wikimedia.org/T273041#6793152>, @ItamarWMDE wrote: > I don't think it's the Lookup's responsibility to render the Icon, if you want an icon to trigger the popup then an Icon component should be the target of it. Otherwise, we're making a design decision for potentially other implementations of this popover. I think the taintedrefs team (perhaps with less frontend experience so take this all with a pinch of salt) came to the conclusion that the "Popper" shouldn't know much about its surroundings. Both including what it was popping up near but also what might be triggering it to pop up/down. The only real logic we put it in was knowing how to close itself (e.g click the 'x' or focusing off it). The rest of the appearance/disappearance was handled higher up the application. It looks like vuetify offers controlling the tool-tip in a similar way to what tainted-refs did but using `v-model` rather than rather than having a `v-if` element wrapping it (which I think might be nicer). You could even consider this being the only api and not include a way to inject a triggering component at all. A question it might be worth asking is "will popover only ever be triggered by an element being clicked or hovered or will they sometimes be triggered by some other application state change?" TASK DETAIL https://phabricator.wikimedia.org/T273041 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tarrow Cc: Tarrow, Michael, ItamarWMDE, Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
