zeljkofilipin added a comment.

  Looks like @awight's latest patch makes the wdio tests run in CI.
  
  I find some of my comments from 2019 still stand (T222200#5172117 
<https://phabricator.wikimedia.org/T222200#5172117>). I'll quote relevant parts:
  
  In T222200#5172117 <https://phabricator.wikimedia.org/T222200#5172117>, 
@zeljkofilipin wrote:
  
  > - The convention is to have Selenium tests (including `wdio.conf.js`) in 
`tests/selenium`, if possible. See Selenium/Node.js#write-tests 
<https://www.mediawiki.org/wiki/Selenium/Node.js#write-tests> for examples.
  > - There is no need for selenium-standalone (Gruntfile.js#273 
<https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query/gui/+/master/Gruntfile.js#273>).
 Use Chromedriver instead. It should be available in CI.
  
  
  
  - Is there a reason this repository doesn't have Selenium tests in 
`tests/selenium`?
  - Is there a reason this repository uses `selenium-standalone` instead of 
`chromedriver`?

TASK DETAIL
  https://phabricator.wikimedia.org/T222200

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: zeljkofilipin
Cc: Tonina_Zhelyazkova_WMDE, Lucas_Werkmeister_WMDE, Addshore, awight, 
Smalyshev, hashar, zeljkofilipin, noarave, WMDE-leszek, Aklapper, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, 
alaa_wmde, Ferenczy, sarhan.alaa, Samuditha24, IM3847, joker88john, CucyNoiD, 
Nandana, kostajh, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Jayprakash12345, Chicocvenancio, 
MichaelSchoenitzer_WMDE, QZanden, LawExplorer, Lewizho99, Maathavan, Jogi_don, 
_jensen, rosalieper, xSavitar, Scott_WUaS, Jonas, thcipriani, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, jayantanth, Rxy, Jay8g
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to